-
Notifications
You must be signed in to change notification settings - Fork 23.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
correct and clarify deprecation #45234
Conversation
if module.params['scope'] == 'user': | ||
|
||
''' Set CLI options depending on params ''' | ||
if module.params['user'] is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to handle user == False
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose the way to handle it is:
if module.params['user'] is not None:
module.deprecate("The 'user' option is being replaced by 'scope'", version='2.11')
if module.params['user']:
module.params['scope'] = 'user'
else:
module.params['scope'] = 'system'
The test
|
Looks good now Merge when CI passes and then please open up a backport for me to merge it to stable-2.7 ASAP. |
The test
|
* correct and clarify deprecation (cherry picked from commit 64c594d)
* correct and clarify deprecation (cherry picked from commit 64c594d)
* correct and clarify deprecation (cherry picked from commit 64c594d)
SUMMARY
fixes #45036
ISSUE TYPE
COMPONENT NAME
systemd
ANSIBLE VERSION